tommy/libpostal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[fix] need to calculate max Jaro-Winkler for other methods, so only test whether we should use it after we've cycled through all the tokens

Browse Source
This commit is contained in:
Al
2018-01-06 03:59:34 -05:00
parent 179e6581e5
commit e935f2a036
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/soft_tfidf.c
View File

@@ -285,7 +285,7 @@ double soft_tfidf_similarity_with_phrases_and_acronyms(size_t num_tokens1, char
} }
double jaro_winkler = jaro_winkler_distance_unicode(t1u, t2u); double jaro_winkler = jaro_winkler_distance_unicode(t1u, t2u);
if (use_jaro_winkler && jaro_winkler > max_sim) { if (jaro_winkler > max_sim) {
max_sim = jaro_winkler; max_sim = jaro_winkler;
argmax_sim = j; argmax_sim = j;
} }
@@ -316,7 +316,7 @@ double soft_tfidf_similarity_with_phrases_and_acronyms(size_t num_tokens1, char
// Jaro-Winkler is still used to calculate similarity // Jaro-Winkler is still used to calculate similarity
if (!have_acronym_match && !have_phrase_match) { if (!have_acronym_match && !have_phrase_match) {
if (max_sim > jaro_winkler_min || double_equals(max_sim, jaro_winkler_min)) { if (use_jaro_winkler && (max_sim > jaro_winkler_min || double_equals(max_sim, jaro_winkler_min))) {
log_debug("have max sim = %f\n", max_sim); log_debug("have max sim = %f\n", max_sim);
t2_score = token_scores2[argmax_sim]; t2_score = token_scores2[argmax_sim];
total_sim += max_sim * t1_score * t2_score; total_sim += max_sim * t1_score * t2_score;