[fix] sign comparison in regularized gradient computation for logistic regression

2016-01-26 01:16:11 -05:00
parent ae2b839f17
commit ababb8f2d0
1 changed files with 1 additions and 1 deletions
--- a/src/logistic_regression.c
+++ b/src/logistic_regression.c
@@ -156,7 +156,7 @@ static bool logistic_regression_gradient_params(matrix_t *theta, matrix_t *gradi
                double reg_update = theta_ij * lambda;
                double current_value = gradient_values[idx];
                double updated_value = current_value + reg_update;
-                if (fabs(updated_value) == fabs(current_value)) {
+                if ((updated_value > 0) == (current_value > 0)) {
                    gradient_values[idx] = updated_value;
                }
            }