tommy/libpostal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[fix] sign comparison in regularized gradient computation for logistic regression

Browse Source
This commit is contained in:
Al
2016-01-26 01:16:11 -05:00
parent ae2b839f17
commit ababb8f2d0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/logistic_regression.c
View File

@@ -156,7 +156,7 @@ static bool logistic_regression_gradient_params(matrix_t *theta, matrix_t *gradi
double reg_update = theta_ij * lambda; double reg_update = theta_ij * lambda;
double current_value = gradient_values[idx]; double current_value = gradient_values[idx];
double updated_value = current_value + reg_update; double updated_value = current_value + reg_update;
if (fabs(updated_value) == fabs(current_value)) { if ((updated_value > 0) == (current_value > 0)) {
gradient_values[idx] = updated_value; gradient_values[idx] = updated_value;
} }
} }