tommy/libpostal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[crf] in averaged perceptron training for the CRF, need to update transition features when either guess != truth or prev_guess != prev_truth

Browse Source
This commit is contained in:
Al
2017-03-11 05:58:11 -05:00
parent a6eaf5ebc5
commit 7562cf866b
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/crf_trainer_averaged_perceptron.c
View File

@@ -539,7 +539,7 @@ bool crf_averaged_perceptron_trainer_update(crf_averaged_perceptron_trainer_t *s
truth = labels[t];
guess = viterbi[t];
if (t > 0 && guess != truth) {
if (t > 0 && (guess != truth || prev_guess != prev_truth)) {
uint32_t idx = indptr[t];
uint32_t next_start = indptr[t + 1];
@@ -580,7 +580,7 @@ bool crf_averaged_perceptron_trainer_update(crf_averaged_perceptron_trainer_t *s
truth = labels[t];
guess = viterbi[t];
if (t > 0 && guess != truth) {
if (t > 0 && (guess != truth || prev_guess != prev_truth)) {
if (!crf_averaged_perceptron_trainer_update_trans_feature(self, prev_guess, prev_truth, guess, truth, value)) {
return false;
}
@@ -593,6 +593,7 @@ bool crf_averaged_perceptron_trainer_update(crf_averaged_perceptron_trainer_t *s
return true;
}
bool crf_averaged_perceptron_trainer_train_example(crf_averaged_perceptron_trainer_t *self, void *tagger, void *tagger_context, cstring_array *features, cstring_array *prev_tag_features, tagger_feature_function feature_function, tokenized_string_t *tokenized, cstring_array *labels) {
if (self == NULL || self->base_trainer == NULL) return false;